[cmb69]

The test fails since PR #15847 has been merged. This patch should fix the test, but is certainly not complete. I haven't had the time to look closer into this issue, but it seems that the assumption that a persistent constant also has a persistent filename is not generally valid (in this case, dl() is involved). So this needs closer investigation, but this fix might be pulled to get CI back to green.

[iluuu1994]

Thank you for having a look. If this only happens with dl(), it should indeed be harmless, but in the general sense internal things should be persistent. I'll let you decide whether it's worth adjusting. 🙂

[cmb69]

Indeed, this only happens with dl(), so I've adapted the test to avoid it (it's not needed to verify the bug fix anyway; was just a convenience).

[iluuu1994]

Do you know why dl() results in the string being non-persistant?

[cmb69]

Do you know why dl() results in the string being non-persistant?

php-src/Zend/zend_language_scanner.l

Line 798 in 063de1f

filename_str = zend_string_init(filename, strlen(filename), 0);

backtrace

>	php8ts_debug.dll!compile_string(_zend_string * source_string, const char * filename, _zend_compile_position position) Zeile 799	C
 	php8ts_debug.dll!zend_eval_stringl(const char * str, unsigned __int64 str_len, _zval_struct * retval_ptr, const char * string_name) Zeile 1342	C
 	php8ts_debug.dll!zend_eval_stringl_ex(const char * str, unsigned __int64 str_len, _zval_struct * retval_ptr, const char * string_name, bool handle_exceptions) Zeile 1396	C
 	php8ts_debug.dll!zend_eval_string_ex(const char * str, _zval_struct * retval_ptr, const char * string_name, bool handle_exceptions) Zeile 1407	C
 	php.exe!do_cli(int argc, char * * argv) Zeile 965	C
 	php.exe!main(int argc, char * * argv) Zeile 1310	C
 	[Externer Code]	

php-src/sapi/cli/php_cli.c

Line 965 in 063de1f

zend_eval_string_ex(exec_direct, NULL, "Command line code", 1);

So while I still think that it makes sense to rewrite the test to avoid dl(), the assumption that the filename is persistent, if the constant is persistent, is not necessarily valid. This has nothing to do with com_dotnet; simple reproducer:

php -r 'dl("curl");'

Or any other extension which registers constants, and is not already loaded.

[iluuu1994]

Oh, I just understood the problem. It's that dl() is executed while EG(current_execute_data) is set, so zend_get_executed_filename_ex() will link the current user file to the extensions constant when it shouldn't (as internal extensions don't have a file name). Not sure yet what the best fix is.

[cmb69]

I have now merged this PR so we have green CI on Windows. We can cater to a more general later.