Repository navigation
Fix intl tests failed because of missing skipif section - #162
Merged
Merged
Conversation
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 12, 2026
Problem Jordan ruled that nothing nests: every type, events and interfaces included, is declared at file level in a namespace, in its own file. The section 15 note still named a nested event `App\Order\Paid`, autoloaded it through its outer class, resolved a bare name to the nested type first, read a dotted type and `new X.Y`, and asked Jordan three questions he has since answered. Solution The note opens with the ruling and names every PR whose scope shrinks or changes: mago-sharp PR 1 (php#162) and PR 3, php-sharp PR A and the spec-files PR. Decisions 1 (nested-type naming) and 6 (autoload through the outer class) go, and the rest take new numbers. Language rule 6 is now the nested-type refusal, and rule 7 goes. The questions become Jordan's rulings, `extern event … uses` gives the class its effects, and `Effect::Emit` carries no payload. Every example names `OrderPaid` and `OrderEvent`, and the states php#162 now shows, on the checker and on the engine, are quoted from a run. docs/architecture/slices/ └── 15-events.md the ruling, the PRs it reshapes, and file-level names throughout
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 12, 2026
…tructors, events and init Mago php#152 merged Mago master's named constructors (php#161), events (php#162) and the `init` accessor (php#169), so this branch pinned a Mago without them, and the spec examples that use them still failed here. The engine now builds from Mago 1b517f4e0. The generated header changes only in the commit it names. Six more spec examples pass and leave the baseline, written with the `cp` command `sharp/bin/test --spec` prints: - §9.1 constructor-call-this, named-constructors and set-once - §15 extern-event, extern-event-effects and standalone-event ext/sharp/sharp_unit.h <- names Mago 1b517f4e0 sharp/baseline/spec <- the six examples that now pass leave it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many intl test cases missing skipif section to detect if extension available. and some of them miss a '<?php' see: https://github.com/reeze/php-src/pull/new/php:master...reeze:fix-intl-tests#diff-0
Those test cases are in master only :)
Thanks