Repository navigation
Conversation
|
please merge them into one commit. it will be easier for us to see what exactly you have committed. |
|
I've updated the branch to be 1 commit. Thank you! On Mon, Aug 6, 2012 at 3:00 AM, Xinchen Hui <
Lonny Kapelushnik |
Added 2nd, optional, param to assert. When passed in it will be added to the printed warnings and passed as a 4th param to a callback
|
I apologize. I had some extra files I accidentally committed earlier. I've removed them and recommitted the correct files in 1 commit. |
There was a problem hiding this comment.
should be description_len
|
This is quite cool, as it enables testing framework authors to use assert() as a base for assertions. |
|
Thank you, we’re getting closer. See my other remarks. |
|
Lars, Thanks for reviewing this. The spacing issue was b/c I was using two different editors. This is now fixed. Also, you were correct that variable length arrays are not C89. I switched it to use safe_emalloc instead. |
There was a problem hiding this comment.
The leading space before description_len is wrong here
|
Thanks. I will test the patch locally this weekend. I'll keep you updated. |
|
Comment on behalf of lstrojny at php.net: Thanks for your contribution. The patch has been merged into 5.4 and master. |
Problem: The generics Mago branch merged Mago master 6720097 (#150, PHP# modules) as 1a5f79c, so `ext/sharp/sharp_unit.h` pinned a Mago head the branch has moved past. Solution: `ext/sharp/sharp_unit.h` is the header Mago 1a5f79c generates. Only `SHARP_MAGO_COMMIT` changes, since #150 adds no node kind and `SHARP_UNIT_ABI` stays the same. `php -n --ri sharp` prints "Mago commit => 1a5f79c…", and `sharp/bin/test` passes 202 of 202 tests. ext/sharp/sharp_unit.h <- pinned to Mago 1a5f79c
5 participants
Added 2nd, optional, param to assert. When passed in it will be added to the printed warnings and passed as a 4th param to a callback