Skip to content

Fix GH-14834: Error installing PHP when --with-pear is used - #14837

Closed
ndossche wants to merge 1 commit into
php:PHP-8.2from
ndossche:fix-14834
Closed

ndossche wants to merge 1 commit into
php:PHP-8.2from
ndossche:fix-14834

Conversation

@ndossche

@ndossche ndossche commented Jul 5, 2024

Copy link
Copy Markdown
Member

libxml2 2.13 makes changes to how the parsing state is set, update our code accordingly. In particular, it started reporting entities within attributes, while it should only report entities inside text nodes.

@ndossche ndossche linked an issue Jul 5, 2024 that may be closed by this pull request
libxml2 2.13 makes changes to how the parsing state is set, update our
code accordingly. In particular, it started reporting entities within
attributes, while it should only report entities inside text nodes.

@devnexen devnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndossche ndossche closed this in 67259e4 Jul 6, 2024
Vinealius pushed a commit to Vinealius/php-src that referenced this pull request Oct 6, 2026
libxml2 2.13 makes changes to how the parsing state is set, update our
code accordingly. In particular, it started reporting entities within
attributes, while it should only report entities inside text nodes.

Closes phpGH-14837.
Vinealius pushed a commit to Vinealius/php-src that referenced this pull request Oct 6, 2026
libxml2 2.13 makes changes to how the parsing state is set, update our
code accordingly. In particular, it started reporting entities within
attributes, while it should only report entities inside text nodes.

Closes phpGH-14837.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error installing PHP when --with-pear is used

3 participants