Skip to content

Fix GH-11188: Error when building TSRM in ARM64 (for IR JIT) - #14459

Merged
ndossche merged 1 commit into
php:masterfrom
ndossche:ir-11236
Jun 4, 2024
Merged

ndossche merged 1 commit into
php:masterfrom
ndossche:ir-11236

Conversation

@ndossche

@ndossche ndossche commented Jun 3, 2024

Copy link
Copy Markdown
Member

This is GH-11236 for IR JIT.
TSRM change is the same.
The only real difference is the place where the tsrm_tls_offset and tsrm_tls_index are filled in for FreeBSD but the code is otherwise identical.
Asking @arnaud-lb for review as he did it for the 8.2 & 8.3 version.

@petk

petk commented Jun 3, 2024

Copy link
Copy Markdown
Member

Not related to this issue probably, but there is also some bug happening on FreeBSD 32-bit when building with Clang (default) on all branches (tested with PHP-8.3 and master):

ld: error: relocation R_386_32 cannot be used against local symbol; recompile with -fPIC
>>> defined in ext/opcache/.libs/zend_accelerator_debug.o
>>> referenced by zend_accelerator_debug.c:58 (ext/opcache/zend_accelerator_debug.c:58)
>>>               ext/opcache/.libs/zend_accelerator_debug.o:(zend_accel_error_va_args)

This is something related?

@ndossche

ndossche commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

This is something related?

Different issue than this, I can check that out sometime this week, but I'd have to setup a VM with FreeBSD 32-bit first.

@petk

petk commented Jun 3, 2024

Copy link
Copy Markdown
Member

Ok, no problem. I'll open a bug at some point on the way...

@arnaud-lb arnaud-lb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndossche
ndossche merged commit 89c4e4c into php:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants