Repository navigation
Fix GH-11188: Error when building TSRM in ARM64 (for IR JIT) - #14459
Merged
Merged
Conversation
This is phpGH-11236 for IR JIT.
Member
|
Not related to this issue probably, but there is also some bug happening on FreeBSD 32-bit when building with Clang (default) on all branches (tested with PHP-8.3 and master): This is something related? |
Member
Author
Different issue than this, I can check that out sometime this week, but I'd have to setup a VM with FreeBSD 32-bit first. |
Member
|
Ok, no problem. I'll open a bug at some point on the way... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is GH-11236 for IR JIT.
TSRM change is the same.
The only real difference is the place where the tsrm_tls_offset and tsrm_tls_index are filled in for FreeBSD but the code is otherwise identical.
Asking @arnaud-lb for review as he did it for the 8.2 & 8.3 version.