Repository navigation
Fix typo in LDAP stub - #14313
Merged
Merged
Fix typo in LDAP stub#14313
Conversation
Member
|
Yup, I think so too... |
Contributor
Author
|
I probably should have opened an issue first but re-opening this to see whether this was indeed a typo or not. |
Member
|
Thanks for reporting this and opening a PR. This probably could even go into PHP-8.2 branch but it would introduce 3 new PHP constants in case of Oracle client's ldap implementation (this is different than the OpenLDAP):
Because this Interesting that no one has noticed this, I guess these constants were never used. |
petk
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think using
ORALDAPinstead ofHAVE_ORALDAPwhich is used everywhere else was a typo. If it wasn't, feel free to close this PR.