Repository navigation
Conversation
dstogov
reviewed
Apr 10, 2024
dstogov
left a comment
dstogov
left a comment
Member
There was a problem hiding this comment.
I can't test this.
Merge, if you know what you are doing.
Shouldn't this also be back-ported to PHP-8.2?
DTV elements are 8 bytes in size a per ABI [1], and the index is offset by 1 on FreeBSD [2] [1] http://people.redhat.com/drepper/tls.pdf [2] https://github.com/freebsd/freebsd-src/blob/bf56e8b9c8639ac4447d223b83cdc128107cc3cd/libexec/rtld-elf/rtld.c#L5260
arnaud-lb
requested review from
Girgias,
TimWolla,
adoy,
alexdowad,
bukka,
derickr,
devnexen,
kocsismate and
ndossche
as code owners
May 28, 2024 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #13927, FreeBSD uses 8 bytes DTV fields on x86-64.
Also, the module ID is offset by 1