Repository navigation
Changed the test expected result of `pdo_mysql/bug76815 to %d - #13808
Conversation
…o %d MariaDB was reporting row 0 instead of 1.
db3d893 to
9f72f47
Compare
Upstream as php/php-src#13808
|
Thanks for working on this, but there's already a PR. If the SSL issue is resolved, I can merge it... |
|
Ack, are you waiting for assistance on anything explicitly that I can help with? |
|
If you don't mind, I would be very grateful if you could check that out. Using 11.4-rc was not enough. I was planning to try and figure out how to set up SSL over the weekend, but it would be very helpful if someone knowledgeable in MariaDB could check it for me. |
kamil-tekiela
left a comment
kamil-tekiela
left a comment
There was a problem hiding this comment.
I had some time to look into this now and I found out that this is an intentional change in MariaDB 10.7. https://jira.mariadb.org/browse/MDEV-26635 and https://jira.mariadb.org/browse/MDEV-10075
So apparently, we cannot check that the row matches anymore, which in this case makes sense as the 1/0 value is just a placeholder due to the error message being a generic error.
* up/master: (180 commits) Changed the test expected result of `pdo_mysql/bug76815_pdo_mysql_f to %d (php#13808) ext/standard: name the real parameter in the unpack() offset error (php#24215) ext/readline: Refactor CLI readline completion generators Fix phpGH-24081: User opcode DISPATCH runs on a stale frame in the TAILCALL VM ext/standard: Validate the bcrypt cost before reading it JIT: Avoid object type check if the object is known to be a type (php#24086) zend_alloc: move a small block shrunk to the size of the bin below Fix phpGH-23979: Nullsafe operator must not flush delayed oplines of an enclosing function ext/zip: Reject ZipArchive mutators during close() (php#24025) Fix OSS-Fuzz #568005340: FETCH_DIM_FUNC_ARG partial conversion Fix too wide type inference for ASSIGN_DIM_OP Fix type inference of ADD_ARRAY_UNPACK with integer keys Evaluate ZEND_SPACESHIP in SCCP Add range inference for SPACESHIP JIT: Optimize array checks in comparisons (php#24084) Fix leak when the added previous exception is already in the chain (php#24177) date: Add `php_date_time_duration_create()` in a new `time_duration.h` (php#24072) ext/zip: Fix use-after-free in the archive destructor path (php#23779) ext/standard: Optimize array_chunk() by filling packed chunks directly Fix phpGH-17626: JIT corrupts opline handler when blacklisting root trace ...
3 participants
MariaDB was reporting row 0 instead of 1.
Example test run: https://buildbot.mariadb.org/#/builders/237/builds/6717/steps/7/logs/stdio