Skip to content

Fix mysqli tests for MariaDB/MySQL versions exceeding 25 characters - #13625

Closed
grooverdan wants to merge 1 commit into
php:PHP-8.2from
grooverdan:mariadb_big_version
Closed

grooverdan wants to merge 1 commit into
php:PHP-8.2from
grooverdan:mariadb_big_version

Conversation

@grooverdan

Copy link
Copy Markdown
Contributor

Due to an error, MariaDB Docker Official Images containers and MariaDB released Debian/Ubuntu packages ended up with a long version number:

select length(version()),version()'
+-------------------+-----------------------------------------+
| length(version()) | version()                               |
+-------------------+-----------------------------------------+
|                39 | 10.5.23-MariaDB-1:10.5.23+maria~ubu2004 |

https://jira.mariadb.org/browse/MDEV-33631

Even fixing this upstream down to 10.11.23-MariaDB-1~ubu2004 is 27 characters resulting in a truncate to NULL in the changed tests resulting in a test failure.

Example failure changing mysql to mariadb container in test run

========DIFF========
001+ [012] Cannot execute CALL, [1406] Data too long for column 'ver_param' at row 1
002+ [013] Cannot execute CALL, [1406] Data too long for column 'ver_param' at row 1
003+ [018] Results seem wrong, got , [0] 
004+ [021] Cannot execute CALL, [1406] Data too long for column 'ver_param' at row 1
005+ [026] Results seem wrong, got , [0] 
     done!
========DONE========
FAIL mysqli_stmt_execute() - Stored Procedures [ext/mysqli/tests/mysqli_stmt_execute_stored_proc.phpt] 

========DIFF========
--
         string(1) "b"
       }
     }
084+ [024] Expecting array [0] 
085+ array(1) {
086+   ["p_version"]=>
087+   NULL
088+ }
     done!
========DONE========
FAIL mysqli_store_result() [ext/mysqli/tests/mysqli_store_result_copy.phpt] 
=====================================================================

Due to an error, MariaDB Docker Official Images containers and
MariaDB released Debian/Ubuntu packages ended up with a long
version number:

select length(version()),version()'
+-------------------+-----------------------------------------+
| length(version()) | version()                               |
+-------------------+-----------------------------------------+
|                39 | 10.5.23-MariaDB-1:10.5.23+maria~ubu2004 |

https://jira.mariadb.org/browse/MDEV-33631

Even fixing this upstream down to 10.11.23-MariaDB-1~ubu2004
is 27 characters resulting in a truncate to NULL in the changed
tests resulting in a test failure.

@SakiTakamachi SakiTakamachi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SakiTakamachi

Copy link
Copy Markdown
Member

Oh, excuse me. I was already working on this.

#13500

@grooverdan

Copy link
Copy Markdown
Contributor Author

Oh, great to see. I'll keep an eye on how I can help

@grooverdan grooverdan closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants