[marc-mabe]

Renamed DateTime[Immutable]::[get|set]Microseconds() to DateTime[Immutable]::[get|set]Microsecond()

• This is a getter/setter of the microsecond part of the time and not a multiple microseconds
• If you think of hour this gets more clear as it would be [get|set]Hour and not hours

Removed tentative return type as noted here #12557 (comment)

Added getMicrosecond to DateTimeInterface as discussed in #13491

As this hasn't been added to any stable/beta branch it's not a BC break.

[Ayesh]

I think you forgot to run php build/gen_stub.php, so the tests will eventually fail.

As for the method renaming, I'm personally against using microsecond. JS also follows the plural naming pattern (Date.setMilliseconds, Date.setHours, etc). We don't have DateTime::setHour method in the first place, so there is no inconsistency.

[marc-mabe]

@Ayesh This is about one part of the date/time. As that it's about one single microsecond part and does not get/set multiple microseconds.

About JS Date object is nothing I would look at as it's a nightmare in method naming. it's a mixture of singular/plural accessors (getYear vs. getSeconds etc.) - oh you actually have to use getFullYear, a date is a day getDate and a day is day of week getDay and so on.

[Girgias]

I don't really care about the naming but maybe @derickr has opinions?

[kocsismate]

IMO ext/date is already inconsistent with the naming: on one hand, there is already a setMilliseconds() method, but on the other hand, we have a $microsecond parameter in the setTime() method (and all the other parameter names are singular).

BTW: the tentative return type related parts are fine, and thanks for dealing with this!

[marc-mabe]

IMO ext/date is already inconsistent with the naming: on one hand, there is already a setMilliseconds() method, but on the other hand, we have a $microsecond parameter in the setTime() method (and all the other parameter names are singular).

Where is setMilliseconds defined?
I can only find it in Carbon in both singular/plural variants : https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Carbon.php#L339-L340

[kocsismate]

Where is setMilliseconds defined?

Oh... I guess I mixed it up with setMicroseconds... 🤔 Because I cannot find it either.. In which case the renaming makes sense indeed!

[derickr]

After my other merge, this has now a conflict in the generated stub. Can you fix that? I'll then merge this.

[marc-mabe]

After my other merge, this has now a conflict in the generated stub. Can you fix that? I'll then merge this.

@derickr done rebased

[marc-mabe]

@derickr @kocsismate Now added getMicrosecond to DateTimeInterface as well as discussed in #13491