Repository navigation
Add macos-14 to the push and nightly workflows - #13299
Merged
Merged
Conversation
Member
Author
|
Once you have a chance, please have a look at the build failure. It fails when building without capstone as |
Member
This should be fixed via 2bf9f7e |
shivammathur
force-pushed
the
ci-arm64
branch
from
February 1, 2024 10:12
5ac0e7e to
91d4fc7
Compare
Contributor
|
Btw could you target this against PHP-8.2? I believe it's a good idea to run arm64 tests on currently supported versions of PHP as well as the master branch :) |
iluuu1994
reviewed
Feb 1, 2024
shivammathur
force-pushed
the
ci-arm64
branch
from
February 1, 2024 10:46
f799c10 to
1a04dc2
Compare
Since we build with the configuration option --with-sodium, adding libsodium to make sure it is installed
shivammathur
force-pushed
the
ci-arm64
branch
from
February 1, 2024 11:29
1a04dc2 to
a92770e
Compare
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
Member
|
@shivammathur Thanks! Feel free to merge yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
macos-14to the push and nightly workflows to test with arm64 architecture.Ref: https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
This PR also does the following
libsodiumto thebrewaction as it is not installed onmacos-14by default.configure-macosaction as brew's prefix is different inmacos-14.