Skip to content

Zend: fix NO_CALLER_SAVED_REGISTERS for clang. - #13052

Closed
devnexen wants to merge 1 commit into
php:masterfrom
devnexen:i_replace_soname_fnname_zu_clang
Closed

devnexen wants to merge 1 commit into
php:masterfrom
devnexen:i_replace_soname_fnname_zu_clang

Conversation

@devnexen

Copy link
Copy Markdown
Member

applying same logic as gcc only fastcall needs to be countered with no_instrument_function.

applying same logic as gcc only fastcall needs to be countered with
no_instrument_function.
@dstogov

dstogov commented Jan 8, 2024

Copy link
Copy Markdown
Member

I think the original fix for GH-9068 was wrong.
Instead of storing scratch register in the replacement function, we should fix over-optimization for the asm function.
I'll take a look tomorrow.

cc @nielsdos

@dstogov

dstogov commented Jan 9, 2024

Copy link
Copy Markdown
Member

See #13099

@devnexen devnexen closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants