Skip to content

Update JIT nightly config - #12662

Merged
dstogov merged 1 commit into
php:masterfrom
danog:update_nightly_config
Nov 14, 2023
Merged

dstogov merged 1 commit into
php:masterfrom
danog:update_nightly_config

Conversation

@danog

@danog danog commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

@danog
danog marked this pull request as ready for review November 13, 2023 14:42

@dstogov dstogov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I don't see problems.

If we are going to run community tests on ARM then opcache.jit_buffer_size should be reduced to 128M. This may be done conditionally.

@danog

danog commented Nov 13, 2023

Copy link
Copy Markdown
Contributor Author

I'll make sure to lower the JIT buffer size in the (eventual) PR that enables nightly tests on ARM!

@danog

danog commented Nov 14, 2023

Copy link
Copy Markdown
Contributor Author

@dstogov Btw could you or @iluuu1994 or someone else merge this? :)

@dstogov
dstogov merged commit 82dcfd1 into php:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants