Repository navigation
Conversation
f399c42 to
93d2776
Compare
dstogov
left a comment
There was a problem hiding this comment.
I'm not sure, if the fact that extension interned strings are not going to be copied by accel_copy_permanent_strings() may make critical problems.
A potential problem, that during caching, opcache may keep a reference to such string and then another process may use this "invalid" reference. Can you please check if this is possible?
|
@dstogov Ok let me first check if I understood correctly what you see as a potential problem. Is it that the interned string If so, I have done some checking and reading of opcache code. From what I see all strings should go through Are there any other places that I should check or did I miss anything in the above? |
…opcache Also fixes incorrect assertion in ini init that php_dl is always temporary. Closes phpGH-12277
93d2776 to
240a3b3
Compare
I think your analyses should be enough. |
This is alternative fix that uses
zend_interned_strings_switch_storagebefore usingphp_dlto make sure that permanent internet string storage is used instead of request storage. Suggested by @dstogov in #12233