Repository navigation
Conversation
Member
|
Right, I had a brief look and I think this makes sense, thanks for handling this |
mvorisek
reviewed
Feb 8, 2023
iluuu1994
marked this pull request as draft
February 9, 2023 00:00
Member
|
I'll take a look on Moday |
iluuu1994
force-pushed
the
gh-10168-follow-up
branch
from
February 10, 2023 21:53
9abe9c7 to
45c457d
Compare
Member
Author
|
Unfortunately, I don't think Zend/tests/gh10168_6.phpt can be solved without adjusting |
iluuu1994
force-pushed
the
gh-10168-follow-up
branch
from
February 10, 2023 22:33
c959fca to
fcf4ab3
Compare
Member
Author
|
|
iluuu1994
added a commit
that referenced
this pull request
Feb 10, 2023
Also make expression result of assignments consistent, containing the value of the variable from after the destructor has been executed. See phpGH-10168
iluuu1994
force-pushed
the
gh-10168-follow-up
branch
from
February 11, 2023 13:46
2600712 to
695fe86
Compare
Member
Author
|
Closed in favor of #10606. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make expression result of assignments consistent, containing the value of the variable from after the destructor has been executed.
See GH-10168
This will be backported to PHP-8.1 but runs against master CI to prove ASAN passes.
/cc @nielsdos (Can't add you as a reviewer)