Time zone bug with \DateTimeInterface::diff() #9866

Activity

1. jack-worman

   added

   Bug

   Status: Needs Triage

   on Nov 1, 2022
2. jack-worman

   changed the title [-]Bug introduced in PHP 8.[/-] [+]Time zone bug with \DateTimeInterface::diff()[/+] on Nov 1, 2022
3. devnexen

   assigned

   derickr

   on Nov 1, 2022
4. heiglandreas commented on Nov 1, 2022

   

   heiglandreas

   on Nov 1, 2022

   Contributor

   More actions

   That looks like the documentation of the parameter absolute is a bit ... off?
5. cmb69

   added

   Extension: date

   on Nov 1, 2022
6. hormus commented on Nov 4, 2022

   

   hormus

   on Nov 4, 2022

   Last edited by hormus

   More actions

   The return value more specifically represents the clock-time interval to apply to the original object ($this or $originObject) to arrive at the $targetObject. This process is not always reversible.
   

   Without absolute

   <?php
   
   $start = new \DateTime('2000-11-01 09:29:22.907606', new \DateTimeZone('America/Chicago'));
   $end = new \DateTime('2022-06-06 11:00:00.000000', new \DateTimeZone('America/New_York'));
   $result = $start->diff($end);
   var_export($result->y);
   
   ?>

   Yes bug, DateTimeImmutable from php 5.5.0, diff from php 5.3.0 expected result is 21.

   <?php
   $utc = new \DateTimeZone('UTC');
   $london = new \DateTimeZone('Europe/London');
   
   $test1 = new \DateTime('2018-01-31', $utc);
   $test2 = new \DateTime('2018-03-31 00:00:00', $london);
   
   $dateDiff = $test2->diff($test1); // true absolute Should the interval be forced to be positive
   //$dateDiff = $test1->diff($test2);
   $bugs = array('y' => &$dateDiff->y, 'm' => &$dateDiff->m, 'd' => &$dateDiff->d, 'h' => &$dateDiff->h, 'invert' => &$dateDiff->invert, 'days' => &$dateDiff->days);
   $test3 = new \DateTime('+2 month ' . $test1->format('Y-m-d\\TH:i:s\\Z'));
   
   var_dump($test3->format('Y-m-d H:i:s +00:00'), $bugs, $dateDiff->format('%r%a'));
   
   ?>

   Expected result: (only php < 8.1.10)

   string(26) "2018-03-31 00:00:00 +00:00"
   array(6) {
     ["y"]=>
     int(0)
     ["m"]=>
     int(1)
     ["d"]=>
     int(30)
     ["h"]=>
     int(23)
     ["invert"]=>
     int(1)
     ["days"]=>
     int(58)
   }
   string(3) "-58"
   

   Expected result $dateDiff = $test1->diff($test2): (only php < 8.1.10)

   string(26) "2018-03-31 00:00:00 +00:00"
   array(6) {
     ["y"]=>
     int(0)
     ["m"]=>
     int(1)
     ["d"]=>
     int(27)
     ["h"]=>
     int(23)
     ["invert"]=>
     int(0)
     ["days"]=>
     int(58)
   }
   string(2) "58"
   
7. derickr

   added a commit that references this issue on Nov 30, 2022

   Fixed phpGH-9699, phpGH-9866, and phpGH-9880 (problems with diff); and …

   ...

   d021851
8. derickr commented on Nov 30, 2022

   

   derickr

   on Nov 30, 2022

   Member

   More actions

   Now fixed, for PHP 8.1.14 and PHP 8.2.1.
9. derickr

   closed this as completedon Nov 30, 2022