Skip to content

Cacheline demote optimization for JITTed code is missing #12825

Closed

Description

@PeterYang12

Description

Hi maintainers, This #11101 supports Cacheline demote and got merged in PHP-8.3.0.
I can see it:

$ git tag --contain 6bd5464
php-8.3.0RC1
php-8.3.0RC2
php-8.3.0RC3
php-8.3.0RC4
php-8.3.0RC5
php-8.3.0RC6
php-8.3.0alpha1
php-8.3.0alpha2
php-8.3.0alpha3
php-8.3.0beta1
php-8.3.0beta2
php-8.3.0beta3

However, in the latest codes, in the master branch, it's gone. And I can't find the implementation. For example, this fucntion https://github.com/php/php-src/blob/566100d7fef86e0061bad67f0ec56f659591bcc7/ext/opcache/jit/zend_jit_ir.c#L15741C53-L15741C53

Is there a specific reason why the optimization was removed, or was it accidentally removed during the process?
Given that the function lacks an implementation, it might fail to build on some machines.
If this task is still ongoing, our team would be very interested in participating or assisting with it.

Looking forward to your response :)

PHP Version

master

Operating System

No response

Activity

  1. dstogov commented on Dec 1, 2023

    @dstogov
    Member

    The support for CLDEMOTE was removed occasionally.

    I've added support for CLDEMOTE in IR Framework via dstogov/ir@ed4fd9e and restored in php JIT via bf6b66f

  2. PeterYang12 commented on Dec 1, 2023

    @PeterYang12
    ContributorAuthor

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions