3 stack limit tests failing on Alpinelinux PHP 8.3 #12643

Activity

1. andypost

   added

   Bug

   Status: Needs Triage

   on Nov 10, 2023
2. andypost commented on Nov 10, 2023

   

   andypost

   on Nov 10, 2023

   ContributorAuthor

   More actions

   Probably @arnaud-lb is the author
3. andypost commented on Nov 10, 2023

   

   andypost

   on Nov 10, 2023

   ContributorAuthor

   More actions

   One more test failed in CI (maybe because of some concurrency)

   TEST 4090/16862 [Zend/tests/stack_limit/stack_limit_003.phpt]
   ========DIFF========
   001- array(4) {
   002-   ["base"]=>
   003-   string(%d) "0x%x"
   004-   ["max_size"]=>
   005-   string(%d) "0x%x"
   006-   ["position"]=>
   007-   string(%d) "0x%x"
   008-   ["EG(stack_limit)"]=>
   009-   string(%d) "0x%x"
   010- }
   011- Maximum call stack size of %d bytes reached. Infinite recursion?
   012- Maximum call stack size of %d bytes reached. Infinite recursion?
   013- Maximum call stack size of %d bytes reached. Infinite recursion?
   001+ Fatal error: Maximum call stack size of 81920 bytes reached during compilation. Try splitting expression in /builds/alpine/aports/testing/php83/src/php-8.3.0RC6/Zend/tests/stack_limit/stack_limit_003.php on line 3
   ========DONE========
   
4. arnaud-lb commented on Nov 10, 2023

   

   arnaud-lb

   on Nov 10, 2023

   Member

   More actions

   I could not reproduce this locally on Alpine 3.18 x86_64. I've configured php with CC=clang ./configure --disable-all --enable-zend-test --with-external-pcre.

   The stack size in the error message Maximum call stack size of 81920 bytes reached during compilation looks suspicious. Either the stack size detection has gone wrong, or the stack size of the process is really small.

   Could you share the output of these commands ?

   $ ulimit -s
   $ sapi/cli/php -r 'var_dump(zend_test_zend_call_stack_get());'
   
5. arnaud-lb

   self-assigned this

   on Nov 10, 2023
6. andypost commented on Nov 10, 2023

   

   andypost

   on Nov 10, 2023

   ContributorAuthor

   More actions

   It is reproducible only on ppc64le arch, maybe because of byte-order
7. andypost commented on Nov 10, 2023

   

   andypost

   on Nov 10, 2023

   ContributorAuthor

   More actions

   The whole run with diff in https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1176577
8. andypost commented on Nov 10, 2023

   

   andypost

   on Nov 10, 2023

   Last edited by andypost

   ContributorAuthor

   More actions

   Default musl value is 128kb (80k prior to 1.1.21) according to https://wiki.musl-libc.org/functional-differences-from-glibc.html#Thread-stack-size
9. arnaud-lb commented on Nov 11, 2023

   

   arnaud-lb

   on Nov 11, 2023

   Last edited by arnaud-lb

   Member

   More actions

   Thank you. I was able to reproduce the issue in a ppc64le VM on tests stack_limit_011.phpt and stack_limit_012.phpt.

   These tests set a stack limit that is too low, so it is reached too soon on this arch.

   The 81920 bytes in the error message is actually correct: this is 128KiB minus zend.reserved_stack_size (ZEND_ALLOCA_MAX_SIZE+16*1024 by default). The error message is confusing.

   Could you confirm that this branch resolves the issue? PHP-8.3...arnaud-lb:php-src:gh12643

   🎉React with 🎉1Reacted by Andy Postnikov
10. arnaud-lb

    removed

    Status: Needs Triage

    on Nov 11, 2023
11. arnaud-lb

    added a commit that references this issue on Nov 11, 2023

    Fix phpGH-12643: Stack limit tests failing on ppc64le

    ...

    This issue will close once commit bcd7207 is merged into the 'master' branch.

    bcd7207
12. andypost commented on Nov 11, 2023

    

    andypost

    on Nov 11, 2023

    ContributorAuthor

    More actions

    Thank you a lot!
    Tests passed https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1178440

    PS: good to know that bug was in tests)

    👍React with 👍1Reacted by Arnaud Le Blanc
13. andypost

    changed the title [-]3 stack limit tests failing on Alpinelinux[/-] [+]3 stack limit tests failing on Alpinelinux PHP 8.3[/+] on Nov 20, 2023
14. bukka commented on Nov 23, 2023

    

    bukka

    on Nov 23, 2023

    Member

    More actions

    @arnaud-lb might be worth to create a PR and merge it...

    👍React with 👍1Reacted by Andy Postnikov
15. arnaud-lb

    added a commit that references this issue on Dec 10, 2023

    Fix GH-12643: Stack limit tests failing on ppc64le

    ...

    This issue will close once commit dad6912 is merged into the 'master' branch.

    dad6912
16. arnaud-lb

    closed this as completedin dad6912on Dec 10, 2023
17. arnaud-lb

    added a commit that references this issue on Dec 10, 2023

    Merge branch 'PHP-8.3'

    ...

    This issue will close once commit 3c3aba1 is merged into the 'master' branch.

    3c3aba1
18. andypost commented on Dec 10, 2023

    

    andypost

    on Dec 10, 2023

    ContributorAuthor

    More actions

    Thank you