Repository navigation
primitives seem to be passed via reference instead of by value under some conditions when JIT is enabled on windows #11917
Description
Description
The following code:
$a = [2147483647,2147483647,2147483647,3,0,0,32,2147483584,127];
echo crc32(json_encode(bitwise_small_split($a))) . "\n";
echo crc32(json_encode(bitwise_small_split($a))) . "\n";
echo crc32(json_encode(bitwise_small_split($a))) . "\n";
echo crc32(json_encode(bitwise_small_split($a))) . "\n";
function bitwise_small_split($val)
{
$split = 8;
$vals = [];
$mask = (1 << $split) - 1;
$i = $overflow = 0;
$len = count($val);
$val[] = 0;
$remaining = 31;
while ($i != $len) {
$digit = $val[$i] & $mask;
$val[$i] >>= $split;
if (!$overflow) {
$remaining -= $split;
$overflow = $split <= $remaining ? 0 : $split - $remaining;
if (!$remaining) {
$i++;
$remaining = 31;
$overflow = 0;
}
} elseif (++$i != $len) {
$tempmask = (1 << $overflow) - 1;
$digit |= ($val[$i] & $tempmask) << $remaining;
$val[$i] >>= $overflow;
$remaining = 31 - $overflow;
$overflow = $split <= $remaining ? 0 : $split - $remaining;
}
$vals[] = $digit;
}
while ($vals[count($vals) - 1] == 0) {
unset($vals[count($vals) - 1]);
}
return array_reverse($vals);
}With this php.ini:
zend_extension = C:/php/ext/php_opcache.dll
[opcache]
opcache.enable=1
opcache.enable_cli=1
opcache.memory_consumption=128
opcache.interned_strings_buffer=16
opcache.max_accelerated_files=100000
opcache.jit_buffer_size=128M
opcache.jit=tracing
Resulted in this output:
48207660
48207660
1497456976
1497456976
But I expected this output instead:
48207660
48207660
48207660
48207660
I get the expected output when I set opcache.enable to 0 in the php.ini but not when it's set to 1.
Note that sometimes I need to run the PHP file twice before the issue starts appearing. Also, this appears to only be a problem on Windows as I was unable to duplicate the issue with https://github.com/phpseclib/docker-php/tree/8.2jit
PHP Version
Operating System
Windows 11
Activity
[-]primitives seem to be passed via reference instead of by value under some conditions when opcache is enabled[/-][+]primitives seem to be passed via reference instead of by value under some conditions when opcache is enabled on windows[/+]ndossche commentedon Aug 9, 2023
What happens if you enable opcache and only disable JIT? I suspect the real issue might be in the JIT instead of opcache.
[-]primitives seem to be passed via reference instead of by value under some conditions when opcache is enabled on windows[/-][+]primitives seem to be passed via reference instead of by value under some conditions when JIT is enabled on windows[/+]terrafrost commentedon Aug 9, 2023
@nielsdos - good call. The following php.ini does not demonstrate the problem:
I've updated my post accordingly.
gmutinel commentedon Sep 19, 2023
Same thing with 8.1.23 on Win11, had to force jit off with
parallels999 commentedon Sep 19, 2023
Me too, on Win 10 with 8.2
Add test for php#11917
dstogov commentedon Oct 16, 2023
I can't reproduce the problem on 8.1.26-dev
@nielsdos can you reproduce?
danog commentedon Oct 16, 2023
@dstogov the issue is still present on windows after rebasing on the latest PHP-8.1: https://github.com/php/php-src/actions/runs/6535551162/job/17745266902?pr=12269
ndossche commentedon Oct 16, 2023
@dstogov I can only reproduce it on Windows, not Linux. Reproduces with danog@d788e4f reliably. Bug only occurs when using tracing JIT with optimization level >= 2. Register allocation settings in JIT don't have an influence.
Fixed phpGH-11917: primitives seem to be passed via reference instead…
Fixed GH-11917: primitives seem to be passed via reference instead of…
Merge branch 'PHP-8.1' into PHP-8.2
Merge branch 'PHP-8.2' into PHP-8.3
Merge branch 'PHP-8.3'
Fixed phpGH-11917: primitives seem to be passed via reference instead…