Repository navigation
AbstractResource must be compatible with ResourceInterface::populateFromResponse #181
Description
Hello,
Since migration to php 7.2 I got this error, with the latest tagged version :
Compile Error: Declaration of OpenStack\Common\Resource\AbstractResource::populateFromResponse(Psr\Http\Message\ResponseInterface $response): OpenStack\Common\Resource\AbstractResource must be compatible with OpenStack\Common\Resource\ResourceInterface::populateFromResponse(Psr\Http\Message\ResponseInterface $response): OpenStack\Common\Resource\ResourceInterface
at vendor/php-opencloud/openstack/src/Common/Resource/AbstractResource.php:16
Activity
haphan commentedon Dec 6, 2017
SDK has not been tested with 7.2 since it is relatively new.
I will add php 7.2 to travis.
jjsaunier commentedon Dec 7, 2017
Ok, nice to Know, thanks you, I'll sens PR if I have free Time to fixe that
haphan commentedon Dec 7, 2017
@Prophet777 I just ran tests with php 7.2 and unfortunately, the SDK may require a bit of refactoring as well as breaking backward compatibility.
Fix bug with incompatible class definition reported [here](php-opencl…
phansys commentedon Jan 11, 2018
This bug has nothing to do with PHP 7.2, since the same result occurs with PHP 7.0 or 7.1: https://3v4l.org/dkLdi.
haphan commentedon Feb 5, 2018
Fix issue should be fixed in the latest 3.x and 2.x version. Let me know if it is not the case.