Repository navigation
PHPStan error Promise but does not specify its types: T #235
Description
PHP version: 8.1.22
Description
Method handleRequest() has parameter [...] with generic interface Http\Promise\Promise but does not specify its types: T
How to reproduce
<?php
declare(strict_types=1);
use Http\Client\Common\Plugin;
use Http\Promise\Promise;
use Psr\Http\Message\RequestInterface;
final class Authentication implements Plugin
{
public function handleRequest(RequestInterface $request, callable $next, callable $first): Promise
{
$request = $request->withHeader('Authorization', 'token bla');
return $next($request);
}
}PHPStan config:
parameters:
level: max
checkMissingIterableValueType: false
treatPhpDocTypesAsCertain: false
paths:
- srcPHPStan playground: https://phpstan.org/r/52113abc-06c9-4058-a970-4be7b8c9b311
ignore Http\Client\Common\Plugin error
Possible Solution
You can add a custom PHPDoc with the correct code, but it seems a bit redundant.
#233 (comment) has an example of this.
/**
* @param callable(RequestInterface): Promise<ResponseInterface> $next
* @param callable(RequestInterface): Promise<ResponseInterface> $first
*
* @return Promise<ResponseInterface>
*/
public function handleRequest(RequestInterface $request, callable $next, callable $first): PromiseAdditional context
Seems #234 is already on the way to get it fixed!
But I could hardly find ANY information about "issue". So creating a new issue for documentation purposes.
Activity
Ndiritu commentedon Nov 15, 2023
Sorry for the delay. Finally getting to focus on this. Working to resolve it today.
dbu commentedon Jan 4, 2024
i reverted the annotations in php-http/promise#33 until we can figure out if there even is a way to correctly do them.
ybelenko commentedon May 11, 2024
How about this:
that's a half measure, but at least something. Following chained Promise will have
mixedtype. We don't chain calls too often in PHP world anyway.dbu commentedon May 16, 2024
hm, yeah why not. it would help at least those those who want to handle the promise, if they don't chain things.
have you tried this in a project with phpstan, does it report mistakes correctly and not report issues when the callback is used correctly? if you did, do you want to do a pull request for this? i think the return should explain that we can't precisely specify the return but explain in words what happens.