Repository navigation
Automatically pull generator and dashboard before using - #50
Conversation
| } | ||
|
|
||
| func (cmd *Dashboard) LaunchDashboard(machine Machine) { | ||
| func (cmd *Dashboard) LaunchDashboard(machine Machine, update bool) { |
There was a problem hiding this comment.
Is update confusing here. True means don;t update, right?
There was a problem hiding this comment.
Ah, I got that flipped. Will fix.
| "-it", | ||
| "-v", fmt.Sprintf("%s:/generated", cwd), | ||
| "--name", | ||
| generator_container_name, |
There was a problem hiding this comment.
Why are we naming the container here?
There was a problem hiding this comment.
Since we name the Dashboard container. Since this might actually be done concurrently I'll remove that.
| cmd.out.Verbose.Println("Launching Dashboard...") | ||
| dash := Dashboard{BaseCommand{machine: cmd.machine, out: cmd.out}} | ||
| dash.LaunchDashboard(cmd.machine) | ||
| dash.LaunchDashboard(cmd.machine, true) |
There was a problem hiding this comment.
If we update every time we start the VM, why would we want to provide the option to not update in the dashboard command. We should remove that and always update.
There was a problem hiding this comment.
My thought was that all containers we use should have an auto-update with the option to suppress.
|
|
||
| // If there was an error it implies no previous instance of the image is available | ||
| // or that docker operations failed and things will likely go wrong anyway. | ||
| if err == nil { |
There was a problem hiding this comment.
Can this be combined with the if err == nil above? its the same check
There was a problem hiding this comment.
Or it doesn;t matter if it exist locally or not. Just always pull it.
Fixes #49