Skip to content

Remove SQLite snapshot install - #23

Open
tekante wants to merge 1 commit into
masterfrom
remove-sqlite-install
Open

tekante wants to merge 1 commit into
masterfrom
remove-sqlite-install

Conversation

@tekante

@tekante tekante commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Docksal CLI images are now based on Debian trixie, which ships SQLite 3.46.1, newer than the 3.45 Drupal 11 needs. The snapshot install of 3.45.1 is rejected by apt as a downgrade (Packages were downgraded and -y was used without --allow-downgrades), and because the RUN step chains commands with ;, the error was swallowed. The step has been a silent no-op, and published images already contain 3.46.1.

Removes the step and the INSTALL_SQLITE build arg from the Dockerfile, build.sh, and the workflow.

Raised in review of #21. Touches default.yml like #21 and #22; whichever merges later needs a trivial rebase.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Changes
    • Simplified the container image build process by removing automatic SQLite upgrade installation.
    • Builds now use the standard SQLite packages available in the base environment rather than selecting an upgraded version based on the PHP version.

Docksal CLI images are now based on Debian trixie, which ships SQLite
3.46.1. The snapshot install of 3.45.1 is rejected by apt as a downgrade
and the error was silently ignored, so the step has been a no-op.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: dc4fefb7-7985-4823-83c5-01b03576f13c
📥 Commits

Reviewing files that changed from the base of the PR and between d519242 and 1bbfa78.

📒 Files selected for processing: 3
  • .github/workflows/default.yml
  • build.sh
  • src/Dockerfile
💤 Files with no reviewable changes: 2
  • src/Dockerfile
  • .github/workflows/default.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The Docker build no longer receives the INSTALL_SQLITE argument. The build script and workflow omit it, and the Dockerfile removes the conditional SQLite 3.x upgrade block.

Changes

SQLite build option removal

Layer / File(s) Summary
Remove conditional SQLite upgrade
.github/workflows/default.yml, build.sh, src/Dockerfile
The workflow and build script no longer pass INSTALL_SQLITE. The Dockerfile removes the argument and the conditional SQLite 3.x upgrade installation. The build script passes only CLI_VERSION.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: mike-potter

Merge Risk: ⚪ Minimal · up to 1bbfa

The obsolete SQLite downgrade path is removed while the documented SQLite capabilities remain available in the base images.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removal of the SQLite snapshot installation and related build configuration.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the build command line,
No SQLite switch remains to find.
The Dockerfile trims its upgrade track,
And sends the old install block back.
One CLI_VERSION leads the way,
While rabbit ears nod, “Done today!”

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant