Repository navigation
Prevent small Bloom filters from matching every entry - #330
Open
Harshil-1603 wants to merge 2 commits into
Open
Harshil-1603 wants to merge 2 commits into
Harshil-1603 wants to merge 2 commits into
Conversation
Assisted-by: OpenAI gpt-6.1-sol
Assisted-by: OpenAI gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a small element count or a high false-positive rate, rounding can produce a zero-byte filter or zero hash functions. An empty filter then reports every entry as present. Clamp newly constructed filters to at least one byte and one hash function.
Closes #253.
The regression covers small element counts and multiple false-positive rates, verifies empty and inserted entries, checks protocol bounds, and round-trips serialization. Existing wire test vectors retain their values.
Validation: all 150 tests, Python compilation and diff checks passed. The regression failed before the fix and passed afterward.
AI assistance: OpenAI Codex, gpt-6.1-sol.