Repository navigation
Conversation
Coalesce same-panel multi-query fetches when enabled via dashboard.spec.queryBatching.mode (off|panel|viewport|dashboard), window flag, or localStorage. Optional getTimeSeriesDataBatch. Unit tests for enablement resolution. Signed-off-by: colivi <charles.olivi@gmail.com>
jgbernalp
reviewed
Sep 28, 2026
|
|
||
| if (batchOn && typeof loaded.getTimeSeriesDataBatch === 'function') { | ||
| const sameKind = definitions.filter((d) => d.spec.plugin.kind === definition.spec.plugin.kind); | ||
| const batchKey = JSON.stringify({ |
Contributor
There was a problem hiding this comment.
This batch key might be missing the fact that there could be different time series datasources in a specific dashboard. Can we test this will not affect a dashboard with different time series datasources configured?
jgbernalp
reviewed
Sep 28, 2026
| import { afterEach, describe, expect, it } from 'vitest'; | ||
| import { isQueryBatchEnabled } from './time-series-queries'; | ||
|
|
||
| describe('isQueryBatchEnabled', () => { |
Contributor
There was a problem hiding this comment.
we might be missing test regarding the actual behavior when querying, it seems the current tests are just focused on configuration
Nexucis
marked this pull request as draft
September 28, 2026 09:41
Member
|
I have put every PRs related to the query batching feature in a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coalesce same-panel multi-query fetches when enabled via dashboard.spec.queryBatching.mode (off|panel|viewport|dashboard), window flag, or localStorage.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.