fix(filter)!: keep operator alias text inside a quoted value

[pdevito3]

Summary

• ParseFilter no longer runs ReplaceLogicalAliases and ReplaceComparisonAliases on the whole input before the parse. These two methods are removed.
• The grammar reads the operator aliases. It tries the aliases first, then the canonical operators.
• On v2, the grammar already resolves query names (fix(filter)!: resolve query names in the grammar again #154). So this PR adds no text rewrite of query names before the parse.

v1.14.2 behavior (and main)

The rewrite before the parse replaces every alias that stands between whitespace with its operator. It does not know about quotes, so it also changes the text inside a quoted value.

New behavior

An alias is an operator only where the grammar expects an operator. A quoted value keeps its text. This includes a value that holds a query name and an alias.

Example

// AndOperator = "and", OrOperator = "or", EqualsOperator = "eq", GreaterThanOperator = "gt"
FilterParser.ParseFilter<Recipe>("""Title eq "salt and pepper or eq gt" and Rating gt 3""", config);

• v1.14.2 and main: x => ((x.Title == "salt && pepper || == gt") AndAlso (x.Rating > 3)).
• This PR: x => ((x.Title == "salt and pepper or eq gt") AndAlso (x.Rating > 3)).

Justification

A quoted value is data. The parser must not change it. With the old rewrite, a caller with word aliases (and, or, eq) cannot search for a value that holds one of these words.

Migration

None for most callers. A caller that relied on the rewrite inside a quoted value must write the canonical operator in the value.

README

The Custom Operators section now tells that operator text inside a quoted value does not change.

Tests

• Unit OperatorAliasTests.alias_text_inside_quoted_value_is_not_replaced
• Unit OperatorAliasTests.case_insensitive_alias_text_inside_quoted_value_is_not_replaced
• Unit OperatorAliasTests.can_use_alias_operator_with_query_name
• Unit OperatorAliasTests.query_name_and_alias_text_inside_quoted_value_is_not_replaced: name eq "name eq x" gives x => (x.Title == "name eq x").
• Integration FilterParsingRegressionTests.operator_alias_text_inside_quoted_value_is_kept (Postgres)

dotnet test: 565 unit tests and 357 Postgres integration tests (Testcontainers) pass, 0 failures.

Rebase on v2

The branch is rebased on v2. The ReplaceQueryNamesWithPropertyPaths helper and the internal ReplaceAliasesWithPropertyPaths overload from the first version are removed, because v2 resolves query names in the grammar.