Skip to content

fix(List): align block content with list markers in Firefox - #12672

Open
minwookshin wants to merge 1 commit into
patternfly:mainfrom
minwookshin:fix/list-content-firefox-alignment
Open

minwookshin wants to merge 1 commit into
patternfly:mainfrom
minwookshin:fix/list-content-firefox-alignment

Conversation

@minwookshin

@minwookshin minwookshin commented Oct 8, 2026 •

Copy link
Copy Markdown

What: Closes #12555.

Removed the inline wrapper from list items without icons so block content stays aligned with the marker in Firefox. Added a regression test and checked ordered/unordered lists in Firefox, Chromium and WebKit, including RTL.

Validation: 92 related tests and 5 snapshots passed; focused TypeScript and changed-file ESLint passed.

Additional issues: None.

Assisted-by: Codex

Summary by CodeRabbit

  • Bug Fixes
    • Block content in list items no longer receives an unnecessary inline wrapper when no icon is present.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9cc1faa2-da22-4bd5-80b5-8bb5c523e8bf
📥 Commits

Reviewing files that changed from the base of the PR and between e72793a and 2a11d69.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/List/__tests__/__snapshots__/ListItem.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • packages/react-core/src/components/List/ListItem.tsx
  • packages/react-core/src/components/List/__tests__/ListItem.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

ListItem now renders children directly when no icon is present. A test verifies that Content is a direct child of ListItem in this case.

Changes

ListItem rendering

Layer / File(s) Summary
Conditional wrapper and regression test
packages/react-core/src/components/List/ListItem.tsx, packages/react-core/src/components/List/__tests__/ListItem.test.tsx
ListItem renders its text wrapper only when an icon is present. The test checks that Content is a direct child of ListItem when no icon is present.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 2a11d

List content without an icon is now a direct child of the list item, addressing the reported block-content alignment problem. No concrete in-repository regression was identified, so the change appears ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing list content alignment with markers in Firefox by removing the unnecessary inline wrapper.
Linked Issues check ✅ Passed Issue #12555 requires removal of the Firefox vertical offset for Content inside ListItem and consistent list alignment across browsers. ListItem.tsx now renders the text wrapper only when icon…
Out of Scope Changes check ✅ Passed The changes are limited to the ListItem rendering condition and its regression test. Both changes directly support the alignment fix for issue #12555. No unrelated implementation or test changes are…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - [List/ListItem/Content] - Content component inside List/ListItem has wrong alignment on Firefox

1 participant