Repository navigation
fix(List): align block content with list markers in Firefox - #12672
minwookshin wants to merge 1 commit into
Conversation
Assisted-by: Codex
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughListItem now renders children directly when no icon is present. A test verifies that Content is a direct child of ListItem in this case. ChangesListItem rendering
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to List content without an icon is now a direct child of the list item, addressing the reported block-content alignment problem. No concrete in-repository regression was identified, so the change appears ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What: Closes #12555.
Removed the inline wrapper from list items without icons so block content stays aligned with the marker in Firefox. Added a regression test and checked ordered/unordered lists in Firefox, Chromium and WebKit, including RTL.
Validation: 92 related tests and 5 snapshots passed; focused TypeScript and changed-file ESLint passed.
Additional issues: None.
Assisted-by: Codex
Summary by CodeRabbit