Skip to content

Do not set id="title" in empty state component #575

Description

@jeff-phillips-18

We shouldn't use id="title" in the empty state message. That's a really generic ID, and IDs need to be unique on the page.

Activity

  1. benjaminapetersen commented on Aug 17, 2017

    @benjaminapetersen
    Member

    @jeff-phillips-18 also curious, does it need to be an h1? Is it tied to style? Perhaps could use class="h1" but on a lesser heading.

  2. jeff-phillips-18 commented on Aug 17, 2017

    @jeff-phillips-18
    MemberAuthor

    I don't believe it needs to be an h1. I will look into that as well.

  3. removed their assignment
    on Sep 12, 2017
  4. dtaylor113 commented on Feb 14, 2018

    @dtaylor113
    Member

    Please see @akieling 's last commit in this Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions