This repository was archived by the owner on Dec 10, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 10, 2019. It is now read-only.
Adding this plugin, stops other plugins working #28
Description
Really having trouble being able to customise PL.
If I add the plugin-node-tab, sass stops working and so does plugin-node-uiextension
This is what I have in patterlab-config.json:
"plugins": {
"plugin-node-tab": {
"enabled": true,
"initialized": false,
"options": {
"tabsToAdd": ["CSS"]
}
},
"plugin-node-uiextension": {
"enabled": true,
"initialized": false,
"options": {
"stylesheets": [
"../../../css/pattern-scaffolding.css"
],
"navLinks": {
"before": [],
"after": []
},
"gearLinks": {
"before": [],
"beforeSearch": []
}
}
}
}
I'm using PL v2.12.0
Thanks in advance
Activity
[-]Adding this plugin, stops other plugins[/-][+]Adding this plugin, stops other plugins working[/+]bmuenzenmeyer commentedon Sep 14, 2018
see https://github.com/pattern-lab/patternlab-node/issues/812
what I imagine is likely happening is a race-condition. they are really only working by accident, a by-product of poor architecting on my part. This was exposed in PL 3 testing.
I need to re-write plugins to support promises instead of events
I will not be backporting a fix to 2.X
Plugin support is basically the last big item in PL 3 and I can only focus on that with my limited bandwidth https://github.com/pattern-lab/patternlab-node/milestone/22