Skip to content
This repository was archived by the owner on Feb 7, 2023. It is now read-only.
This repository was archived by the owner on Feb 7, 2023. It is now read-only.

PatternStates not working as expected #386

Closed

Description

@max-dombrowski

If i add a pattern state by e.g. add @progress to one pattern, every other pattern that includes a pattern or is included by an other pattern get that state.

So adding state "progress" to a pattern, lets say "base-button", all my other patterns that have includes are on progress. Even if they don't include base-button.

In the docs http://patternlab.io/docs/pattern-states.html is can see there is some kind of state inheritance but this can not be the expected behaviour.

Live example:
image
This pattern have no state suffix in filename, Child-pattern ist complete BUT the pattern ist set to in-review because some other pattern is set to in-review.

I used the node-edition earlier where states are working like a charm.
Any ideas?

Activity

  1. carolinmoll commented on Apr 21, 2017

    @carolinmoll

    Same Problem here!

  2. alexcapes commented on Oct 9, 2017

    @alexcapes

    Same issue too.

  3. bradfrost commented on Oct 10, 2017

    @bradfrost
    Member

    @EvanLovely Is this something you've seen in your recent work touching the pattern states feature?

  4. EvanLovely commented on Oct 12, 2017

    @EvanLovely

    Fixed in pattern-lab/patternlab-php-core#139 and released in core v2.8.4

  5. perriard commented on Jan 4, 2018

    @perriard

    I am still having this issue - using the twig standard edition. As I can see the core is still on version 2.0.0. Will the twig version be updated too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions