This repository was archived by the owner on May 13, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on May 13, 2026. It is now read-only.
Consider dropping ./packages #14
Description
Figure out what would be required to drop ./packages from the directory layout. There are some templates that are available in ./packages but maybe those need to go elsewhere in ./source or similar.
Activity
dmolsen commentedon Apr 27, 2016
@aleksip @EvanLovely -
Looking for feedback. If I move
./packages/listeners.jsonand./packages/patternengines.jsonto./configthe only reason for./packagesto exist is the pattern engine-specific templates for the view all view and a generic header/footer inserts. I think I can read them out of./vendorjust fine. Sound ok to ditch./packagesthen? Unified Asset Installer could also go away at that point.EvanLovely commentedon Apr 27, 2016
@dmolsen I like that idea! I had a few issues with
./packages/listeners.jsonbeing gitignored. Not really reproducible or to be worried about, but overall I like the idea of that folder being folded into./vendor.aleksip commentedon May 5, 2016
@dmolsen Sounds good!
dmolsen commentedon May 6, 2016
The
feature-installupdatebranches of the development edition and core (amongst others) now support a new install process. Key points:devrelease I'm hopeful this means we can be "looser" with dependency requirements thereby addressing Don't require very specific dependencies of upstream libraries #9./source/so, again, no more worrying about order./packagesis no more and so is Unified Asset Installer as a dependencyI still need to play with this a bit more. Not a ton changed honestly but I'm sure there may be a quirk or two. Still to do:
v1.0.0designation for at least core and editions. nothing else should have to change.Take a peek at it and let me know what you all think.
aleksip commentedon May 11, 2016
Tried out the
feature-installupdatebranch. Successful install & generate,./packagesnot there,listeners.jsonandpatternengines.jsonfound under./config.Also tested installing with
plugin-data-transform. Successful install & generate, plugin working as expected!dmolsen commentedon May 15, 2016
I was able to get the package uninstall stuff working so I feel pretty comfortable wrapping this up and pushing a release. This is currently a blocker for a number of other ideas that are currently floating around. We will need to coordinate on this as I'd like to reduce conflicts as much as I can.
Again, this will be released as
v1.0.0because it breaks BC. I would like to see editions standardize on the following:.gitignorethat matches the drupal editioncomposer.lockin editions~on packages based on Don't require very specific dependencies of upstream libraries #9 . a future version bump after the Travis work is complete could be completely updated version numbers for packages.I need to check included packages and try to map out how each references core and update how editions refer to them. Meaning, I could need to update
composer.jsonfor the various packages and then push new tags. I feel like pattern lab packages need to reference core as a dependency in case core changes an expected output and we need to tweak a package. But, like I said, I need to draw this out and think it through.Would making this change on Wednesday, May 18 work for people?
EvanLovely commentedon May 15, 2016
That day works for me! Been wanting to wrap up a lot of stuff we're pushing out by depending on 1.x instead of 0.x too.
EvanLovely commentedon May 17, 2016
@dmolsen Just tossing an idea out there: what about bumping core to
v2.0.0instead asv1.0.0feels like the original: pattern-lab/patternlab-php - anyway, just an idea :)dmolsen commentedon May 17, 2016
@EvanLovely my first thought was "no" but when looking at dependencies for the final mustache edition of this it would look odd to be pulling
2.0of PL and be grabbing1.xdependencies. Especiallycore. We'll go with2.0.EvanLovely commentedon May 17, 2016
Awesome!! Agreed!
dmolsen commentedon May 20, 2016
With
v2.0.0out this has been addressed.