This repository was archived by the owner on Jun 27, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 27, 2019. It is now read-only.
Add enable/disable command for plugins #40
Description
Add following feature:
patternlab enable --plugins=plugin-name1, plugin-name2
patternlab disable --plugins=plugin-name1, plugin-name2
Activity
raphaelokon commentedon Oct 11, 2017
@bmuenzenmeyer Is this a viable feature and par with any core functionality?
bmuenzenmeyer commentedon Oct 11, 2017
yes,
as long as by enable and disable, you setting the value inside
patternlab-config.jsonper guidance in the example here: https://github.com/pattern-lab/plugin-node-tab#configurationthis is how plugins will work in 3.X
raphaelokon commentedon Oct 11, 2017
Cool. I will implement it as per spec. Thanks
raphaelokon commentedon Oct 12, 2017
Just had a second look at it … isn't it a bit verbose to just expose plugin-related logic on the config?
This way either the plugin itself has to
(a) return its default configuration or
(b) the CLI has to map that somehow or
(c) the user has to manually add it to the PL config
I prefer
(a)… as this unties the CLI and user from knowing the exact config. Also if different plugins or plugin versions require diff config this would be the easiest way to make sure having a non-breaking setup.raphaelokon commentedon Oct 12, 2017
Actually: The more I think about this the more I feel we should handle it like
babel—let the user enable/config plugins. I am closing this for now