Repository navigation
Updated to new XML API - #9
Open
marcfowler wants to merge 1 commit into
Open
marcfowler wants to merge 1 commit into
marcfowler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got things working with the new API locations using Oauth-based access tokens, since the older mechanism is deprecated for new apps.
I don't have support for refreshing new access tokens yet, but if you already have a valid, non-expired access token you can pass that in and it will get used. So to be clear, you no longer need the 'appName' which was the name of your installation/subdomain nor the API key, but you do need to have already generated the proper access token.
There's likely work that needs to be done before this can be merged all the way back in because we'll almost certainly need that token refresh ability. My usage of it doesn't require it though so perhaps someone else could jump in on that (I am generating the access tokens outside of Node and using them later).