Skip to content

#19: Move jbrowse config - #162

Merged
samrichca merged 7 commits into
feat/jbrowsemvp-arranger3from
move-jbrowse-config
Jun 21, 2023
Merged

samrichca merged 7 commits into
feat/jbrowsemvp-arranger3from
move-jbrowse-config

Conversation

@samrichca

@samrichca samrichca commented Jun 21, 2023 •

Copy link
Copy Markdown
Member
  • rename dms-jbrowse NPM library to dms-jbrowse-components
  • add env variables for jbrowse human genome URLs
  • move config related to loading files to DMS-UI

overture-stack/dms-jbrowse-components#20

@samrichca samrichca changed the title Move jbrowse config #19: Move jbrowse config Jun 21, 2023
<>
<JbrowseLinear
assembly={jbrowseAssemblyObject}
assemblyName={jbrowseAssemblyName}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my initial hunch is one is an Obj and one's a string... but what's the functional difference?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one describes the entire assembly (i.e. which human genome version) and one is just the name in a string which is used in several places.


export const jbrowseAssemblyName = 'hg38';
export const jbrowseAssemblyAlias = 'GRCh38';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to me like this file could be split into separate helpers and contants?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, will do tomorrow

@samrichca
samrichca merged commit 332fcd3 into feat/jbrowsemvp-arranger3 Jun 21, 2023
@samrichca
samrichca deleted the move-jbrowse-config branch June 21, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants