Repository navigation
#19: Move jbrowse config - #162
Merged
Merged
Conversation
…/dms-ui into move-jbrowse-config
| <> | ||
| <JbrowseLinear | ||
| assembly={jbrowseAssemblyObject} | ||
| assemblyName={jbrowseAssemblyName} |
Member
There was a problem hiding this comment.
my initial hunch is one is an Obj and one's a string... but what's the functional difference?
Member
Author
There was a problem hiding this comment.
one describes the entire assembly (i.e. which human genome version) and one is just the name in a string which is used in several places.
|
|
||
| export const jbrowseAssemblyName = 'hg38'; | ||
| export const jbrowseAssemblyAlias = 'GRCh38'; | ||
|
|
Member
There was a problem hiding this comment.
looks to me like this file could be split into separate helpers and contants?
Member
Author
There was a problem hiding this comment.
true, will do tomorrow
justincorrigible
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overture-stack/dms-jbrowse-components#20