Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #71
Summary
plugins/sql-macros/index.ts.$_excludeexpansion, no-data-source behavior, external-source/pragma/non-select bypasses, schema lookup fallback, andSELECT *enforcement.SELECT *prevention works whethernode-sql-parserreturns a single statement object or an array.This is a small SQL macros slice that is non-overlapping with the active/rewarded Durable Object, import/export, LiteREST, handler, worker, operation, cache, RLS, allowlist, plugin registry, stats, cron/resend, and API response coverage PRs.
Validation
.\node_modules\.bin\prettier.CMD --write plugins\sql-macros\index.ts plugins\sql-macros\index.test.ts- passed.\node_modules\.bin\vitest.CMD run plugins\sql-macros\index.test.ts --coverage.enabled true --coverage.include plugins/sql-macros/index.ts --coverage.reporter text --coverage.reportsDirectory coverage-sql-macros- passed;plugins/sql-macros/index.tsreports 91.93% statements, 85.29% branches, 100% functions, 91.8% linesgit diff --check- passedNo UI demo video is included because this is plugin/unit-test coverage with no visible UI behavior.
AI-assisted with Codex; I reviewed the diff and kept the scope to this SQL macros coverage/fix slice.