Skip to content

test: cover LiteREST primary key and request edge cases - #164

Open
obmakesomething wants to merge 1 commit into
outerbase:mainfrom
obmakesomething:codex/chore/literest-coverage
Open

obmakesomething wants to merge 1 commit into
outerbase:mainfrom
obmakesomething:codex/chore/literest-coverage

Conversation

@obmakesomething

Copy link
Copy Markdown

/claim #71

Summary

  • Expands src/literest/index.test.ts with focused coverage for LiteREST primary-key discovery, request parsing, CRUD validation/error branches, and select-query filter construction.
  • Covers PostgreSQL/MySQL primary-key metadata queries, SQLite primary-key filtering, empty REST paths, empty POST/PUT bodies, PATCH without updatable fields, PUT/PATCH/DELETE operation failures, no-primary-key DELETE, and IN/LIKE filter construction with sanitized default ordering.
  • Test-only and intentionally non-overlapping with the active CSV, JSON, dump import, RLS, cache, allowlist, operation, worker, handler, Durable Object, and plugin coverage PRs. No production behavior changes.

Coverage

  • Before this slice, local focused coverage for src/literest/index.ts was 81.94% statements, 66.92% branches, 90.32% functions, 82.67% lines.
  • After this slice, src/literest/index.ts reports 97.68% statements, 83.46% branches, 100% functions, 98.01% lines.

Validation

  • pnpm exec vitest run src/literest/index.test.ts - passed, 38 tests.
  • pnpm exec vitest run src/literest/index.test.ts --coverage.enabled true --coverage.include src/literest/index.ts --coverage.reporter text --coverage.reportsDirectory coverage-literest-after --coverage.thresholds.lines 0 --coverage.thresholds.branches 0 --coverage.thresholds.functions 0 --coverage.thresholds.statements 0 - passed; coverage listed above.
  • pnpm exec prettier --check src/literest/index.test.ts - passed.
  • pnpm run build - passed.
  • git diff --check - passed.
  • pnpm exec vitest run - LiteREST suite passed; current repo baseline still has 4 existing unrelated src/rls/index.test.ts failures.
  • pnpm exec tsc --noEmit --pretty false - no LiteREST test errors; current repo baseline has existing unrelated type errors in plugins/cdc, src/cache/index.test.ts, src/do.test.ts, and src/operation.ts.

No UI demo video is included because this is backend/unit-test-only coverage with no visible UI or runtime behavior change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant