Repository navigation
Conversation
Author
|
Additional verification (2026-05-13 JST):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #71
Summary
Adds focused Vitest coverage for SQL dump import behavior in
src/import/dump.ts.Covered behavior:
SQLite format 3header before execution207with accurate details for mixed success/failure execution500when multipart parsing failssqlFileform valuesconsole.errorspy to avoid mock leakageThis is test-only and intentionally avoids the active CSV, JSON, RLS, cache, operation, worker, handler, allowlist, Durable Object, and plugin coverage PR areas.
Verification
corepack pnpm exec vitest run src/import/dump.test.ts- 13 passedcorepack pnpm exec vitest run src/import/dump.test.ts --coverage.enabled true --coverage.include src/import/dump.ts --coverage.reporter text --coverage.thresholds.lines=0 --coverage.thresholds.branches=0 --coverage.thresholds.functions=0 --coverage.thresholds.statements=0-src/import/dump.tsat 100% statements, 96.15% branches, 100% functions, 100% linescorepack pnpm exec prettier --check src/import/dump.test.ts- passedgit diff --check -- src/import/dump.test.ts- passed with CRLF warning onlycorepack pnpm exec vitest run- dump tests pass; existing unrelated RLS failures remain insrc/rls/index.test.tsDemo video