Repository navigation
test: cover plugin registry beforeQuery chaining - #162
Open
kingzzoov-ctrl wants to merge 1 commit into
Open
kingzzoov-ctrl wants to merge 1 commit into
kingzzoov-ctrl wants to merge 1 commit into
Conversation
Author
|
Quick verification refresh: I re-ran the focused test suite ( stdout | src/plugin.test.ts > StarbasePluginRegistry > should register plugins correctly ✓ src/plugin.test.ts (9 tests) 64ms Test Files 1 passed (1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #71
This PR fixes a small regression in
StarbasePluginRegistry.beforeQueryso each plugin hook receives the previous hook output exactly once, and adds a focused regression test that asserts call counts and arguments across multiple plugins.What changed
await plugin.beforeQuery(opts)call that re-ran every hook with the original query.beforeQueryhook is called exactly once;Demo video
Short local verification demo: https://github.com/kingzzoov-ctrl/starbasedb/releases/tag/starbasedb-pr162-demo-2026-05-13
Artifact details:
starbasedb-pr162-demo-2026-05-13.mp434e4f9abce0a4090ceb74c9237fe1859530581ea98e0f326a4ac06b9794ba30eDemo / verification transcript
Notes
/attempt #71in the issue thread before opening this PR.