Repository navigation
fix(config-manager): Updated polling interval condition. - #208
Merged
Ali Abbas Rizvi (aliabbasrizvi) merged 4 commits intoSep 12, 2019
Merged
Ali Abbas Rizvi (aliabbasrizvi) merged 4 commits into
Ali Abbas Rizvi (aliabbasrizvi) merged 4 commits into
Conversation
Ali Abbas Rizvi (aliabbasrizvi)
approved these changes
Sep 5, 2019
Ali Abbas Rizvi (aliabbasrizvi)
left a comment
Ali Abbas Rizvi (aliabbasrizvi)
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Contributor
|
Please update readme.md for valid polling interval. |
Contributor
|
Please update readme.md for polling interval. |
Mirza Sohail Hussain (msohailhussain)
self-requested a review
September 6, 2019 17:14
| if update_interval < enums.ConfigManager.MIN_UPDATE_INTERVAL: | ||
| # If polling interval is less than or equal to 0 then set it to default update interval. | ||
| if update_interval <= 0: | ||
| self.logger.debug('update_interval value {} too small. Defaulting to {}'.format( |
Contributor
There was a problem hiding this comment.
update_interval value is not greater than zero, Defaulting to {} value. Ali Abbas Rizvi (@aliabbasrizvi) WDYT?
Contributor
There was a problem hiding this comment.
I think current message is fine.
Matt Carroll (mjc1283)
pushed a commit
that referenced
this pull request
Sep 16, 2019
Replica of #208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary