return in finally can swallow exception

In

Line 153 in 40880ff

return

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if any exception is raised from one of the except: clauses, it will not propagate on as expected.

[FSSDK-12497] Fix return in finally block silently swallowing exceptions

[FSSDK-12497] Fix return in finally block silently swallowing excepti…

Irit Katriel (@iritkatriel)

Thanks Irit Katriel (@iritkatriel) for pointing this out. Closing this issue as the PR above fixes it

Navigation Menu