Repository navigation
[FSSDK-10950] refactor ODP implementation - #973
Merged
Merged
Conversation
Raju Ahmed (raju-opti)
marked this pull request as draft
December 6, 2024 13:54
Raju Ahmed (raju-opti)
force-pushed
the
raju/odp-refactor
branch
from
December 9, 2024 16:10
b0b614f to
6378236
Compare
Raju Ahmed (raju-opti)
changed the title
Raju Ahmed (raju-opti)
marked this pull request as ready for review
December 9, 2024 18:54
Raju Ahmed (raju-opti)
requested a review
from Md Junaed Hossain (junaed-optimizely)
December 10, 2024 12:29
Md Junaed Hossain (junaed-optimizely)
approved these changes
Dec 12, 2024
Md Junaed Hossain (junaed-optimizely)
left a comment
Md Junaed Hossain (junaed-optimizely)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
All most all of the issues are regarding copyright text, and some minor cleanups!
Raju Ahmed (raju-opti)
force-pushed
the
raju/odp-refactor
branch
from
December 12, 2024 19:26
dea6ebc to
9bb07f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues