Repository navigation
[FSSDK-10642] Refactor batch event processor - #960
Merged
Merged
Conversation
Raju Ahmed (raju-opti)
marked this pull request as draft
November 14, 2024 18:59
Raju Ahmed (raju-opti)
changed the title
Raju Ahmed (raju-opti)
marked this pull request as ready for review
November 20, 2024 19:01
Mike Chu (mikechu-optimizely)
approved these changes
Nov 20, 2024
Mike Chu (mikechu-optimizely)
left a comment
Mike Chu (mikechu-optimizely)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but woof that was long.
No showstoppers, just some thoughts 👇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues