Repository navigation
chore: removed unused npm package from root - #742
Merged
Zeeshan Ashraf (zashraf1985) merged 2 commits intoFeb 10, 2022
Merged
Conversation
John Nguyen (opti-jnguyen)
approved these changes
Feb 10, 2022
John Nguyen (opti-jnguyen)
left a comment
John Nguyen (opti-jnguyen)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Zeeshan Ashraf (zashraf1985)
deleted the
zeeshan/remove-root-npm-package
branch
February 10, 2022 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Javascript SDK is a monorepo which contains the javascript SDK and supporting packages in
packagessubfolder. We initially had a parent npm package at root to manage subpackages together but its no longer being used. This PR removed that unused npm package and updates readme.Test plan
All existing tests should pass