Repository navigation
Add notin operator - #43
Siyovush Kadyrov (SYOM29) wants to merge 4 commits into
Conversation
|
While we are at it, i think we might as well add an integration test to this feature as well. |
|
Hi! I'm wondering why NotIn operator was not merged in master branch ? |
|
Hi Mark Kordahi (@markikordahi). The NotIn implementation given in that pr was not correct. It was performing the notContains function instead of NotIn. That is the reason I closed the pr. Consecutively I could not find the time to address this. For the other question, the usage of In operator is as follows: new Filter The filter given above should generate the following query: or if case sensitivity is set to false: "(((x.Name.ToLower() == "te".ToLower()) Or (x.Name.ToLower() == " test".ToLower())) Or (x.Name.ToLower() == " testx".ToLower()))" Whenever in doubt about how the DQB will perform on a certain operation you can check our unit tests. The example I gave is from BuildFilterExpressionTests.cs ShouldConvertInOperationToMultipleEquals test case. Hope this helps. |
|
Thanks Siyovush Kadyrov (@SYOM29) for your quick response. let me know if I'm missing anything? I would be happy to contribute with a PR |
|
Mark Kordahi (@markikordahi) I don't know the reason behind the initial design. The solution you are proposing seems feasible to me, but it needs to be tested out. In terms of pr, I don't know who is in charge of managing this repository at this moment. Arda Develioglu (@ardadevelioglu) Can you assign someone to overview DQB? I can review it, no problem, only so that someone in the current team knows what is going on. |
Add NotIn operator.