Skip to content

chore: upgrade k8s for CI, only keeping supported versions - #1657

Merged
metacosm merged 1 commit into
mainfrom
upgrade-k8s-ci
Sep 4, 2023
Merged

chore: upgrade k8s for CI, only keeping supported versions#1657
metacosm merged 1 commit into
mainfrom
upgrade-k8s-ci

Conversation

@metacosm

@metacosm metacosm commented Dec 13, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@metacosm metacosm self-assigned this Dec 13, 2022
@metacosm
metacosm requested a review from csviri December 13, 2022 11:45
@sonarqubecloud

sonarqubecloud Bot commented Dec 13, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@metacosm
metacosm marked this pull request as draft December 13, 2022 13:25
@metacosm

metacosm commented Dec 13, 2022

Copy link
Copy Markdown
Collaborator Author

Looks like the Minikube action (or possibly Minikube itself) is not yet compatible with 1.26.

@github-actions

github-actions Bot commented Feb 12, 2023

Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2023
@github-actions

github-actions Bot commented Feb 26, 2023

Copy link
Copy Markdown

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions Bot closed this Feb 26, 2023
@metacosm metacosm reopened this Feb 26, 2023
@github-actions github-actions Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2023
@github-actions

github-actions Bot commented Apr 29, 2023

Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2023
@metacosm metacosm removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2023
@github-actions

github-actions Bot commented Aug 15, 2023

Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions Bot added the stale label Aug 15, 2023
@openshift-ci openshift-ci Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed stale labels Aug 16, 2023
@metacosm metacosm mentioned this pull request Aug 25, 2023
Closed
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@csviri
csviri marked this pull request as ready for review August 25, 2023 11:10
@openshift-ci
openshift-ci Bot requested review from adam-sandor and andreaTP August 25, 2023 11:10
@csviri csviri self-assigned this Aug 25, 2023
@csviri

csviri commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

updated to most recent supported versions

@metacosm metacosm removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2023
metacosm
metacosm commented Aug 25, 2023
View reviewed changes
Comment thread .github/workflows/pr.yml
matrix:
java: [ 11, 17 ]
kubernetes: [ 'v1.23.15', 'v1.24.9', 'v1.25.5' ]
kubernetes: [ 'v1.25.13', 'v1.26.8', 'v1.27.5', 'v1.28.1' ]

@metacosm metacosm Aug 25, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess we're dropping older versions completely?

@csviri csviri Aug 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good quesiton, before we said (if ai remember correctly, that we will test on supported versions only), but not sure we also say that we will support last n major versions. That might be a better strategy in practice. What do you think?

@metacosm metacosm Aug 25, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that this will increase the CI run time. We could test older versions on main maybe once a day instead of on each PR?

@csviri csviri Aug 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's always a compromise, a shorter build is always better, maybe optimize that when we see that it is too long, not sure if it will be.
It depends also how much of those version we want to run, maybe always the last 6 major versions?

@metacosm metacosm changed the title chore: upgrade k8s versions for CI, remove 1.22, add 1.26 chore: upgrade k8s for CI, only keeping supported versions Aug 25, 2023
@metacosm
metacosm force-pushed the upgrade-k8s-ci branch 2 times, most recently from 324382c to 62d8f24 Compare September 4, 2023 07:51
@metacosm
chore: upgrade k8s versions for CI
f112066 
Signed-off-by: Chris Laprun <metacosm@gmail.com>
@metacosm
metacosm merged commit 4983b30 into main Sep 4, 2023
@metacosm
metacosm deleted the upgrade-k8s-ci branch September 4, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csviri csviri csviri approved these changes
@adam-sandor adam-sandor Awaiting requested review from adam-sandor
@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

@metacosm metacosm

@csviri csviri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metacosm @csviri @openshift-merge-robot