Repository navigation
[Suggestion] Resource Diff Printer #2492
Description
Idea
I'd like to propose an idea.
How about providing a utility function that outputs the diff information to show which fields have changed between the actual resource and the desired resource?
Currently, it seems that such a feature doesn't exist, so when unintended events are generated, we have to log both the actual and desired resources as text and manually compare them field by field to find the differences. This process takes too much time.
Example
override fun match(
actualResource: StatefulSet,
desired: StatefulSet,
primary: OpenSearch,
context: Context<OpenSearch>,
): Matcher.Result<StatefulSet> {
println(ResourceDiffPrinter.printDiff(actualResource, desired))
}"""
Diff :
(actual) -> (desired)
annotations.last-modification-timestamp: "2024-08-13T11:07:04+09:00" -> annotations.last-modification-timestamp: "2024-08-13T12:07:04+09:00"
spec.replicas: "3" -> spec.replicas: "4"
"""
Reacted by Donnerbart
Activity
csviri commentedon Aug 13, 2024
Would make sense IMO, I can imagine that as part of
SSABasedGenericKubernetesResourceMatcher, that could also log this information.Do you plan to also create a PR?
10000-ki commentedon Aug 13, 2024
@csviri
Of course! In that case, would it be okay if I work on it and then submit a PR?
csviri commentedon Aug 13, 2024
sure, pls do! thx!
10000-ki commentedon Aug 16, 2024
@csviri
the PR should be created based on the
nextbranch right??metacosm commentedon Aug 16, 2024
Yes, please.
10000-ki commentedon Nov 11, 2024
done