[Feature Request] Add type to result of condition evaluation

Summary

The current Workflow implementation allows for the registration of dependent ready conditions, which produces a binary result. However, the specific business logic for what "ready" means may contain information that would be useful to propagate to the status of the primary, such as "Conditions".

Proposal (for brainstorming)

Include an additional return type in the signature of the isMet method, which will allow for storing additional information related to the computation of whether the dependent is ready or not.

Example Scenario

Dependent Resource -> Ingress
Is Ready Condition -> Are endpoints externally accessible (DNS record etc), returns status of each
Primary Status Condition -> Are endpoints ready, if not which are pending

This sounds, useful yes!

Note that you can now add arbitrary information to the context and use it later when creating the status here:

java-operator-sdk/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/managed/ManagedDependentResourceContext.java

Lines 26 to 41 in 7e2f3ae

    
             <T> Optional<T> get(Object key, Class<T> expectedType); 
        
             /** 
        
              * Associates the specified contextual value to the specified key. If the value is {@code null}, 
        
              * the semantics of this operation is defined as removing the mapping associated with the 
        
              * specified key. 
        
              * 
        
              * @param <T> object type 
        
              * @param key the key identifying which contextual object to add or remove from the context 
        
              * @param value the value to add to the context or {@code null} to remove an existing entry 
        
              *        associated with the specified key 
        
              * @return an Optional containing the previous value associated with the key or 
        
              *         {@link Optional#empty()} if none existed 
        
              */ 
        
             @SuppressWarnings("unchecked") 
        
             <T> T put(Object key, T value);

feat: allow return additional information for conditions

@btlem

@btlem let us know if the associated PR addresses your use case.

@metacosm

@metacosm Read through the PR and it looks good to me. I agree with the comment that it is general and could be applied to more conditions, though my main use-case is covered here, so this part is mainly nice-to-have for me

Thanks both (+ @csviri ) for the quick action on this!

feat: allow return additional information for conditions

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

feat: allow returning additional information from conditions (#2426)

refactor: clean up informer configuration classes (#2470)

Navigation Menu

Repository navigation

[Feature Request] Add type to result of condition evaluation #2424

Summary

Proposal (for brainstorming)

Example Scenario

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<T> Optional<T> get(Object key, Class<T> expectedType);

	/**
	* Associates the specified contextual value to the specified key. If the value is {@code null},
	* the semantics of this operation is defined as removing the mapping associated with the
	* specified key.
	*
	* @param <T> object type
	* @param key the key identifying which contextual object to add or remove from the context
	* @param value the value to add to the context or {@code null} to remove an existing entry
	* associated with the specified key
	* @return an Optional containing the previous value associated with the key or
	* {@link Optional#empty()} if none existed
	*/
	@SuppressWarnings("unchecked")
	<T> T put(Object key, T value);

[Feature Request] Add type to result of condition evaluation #2424

Description

Summary

Proposal (for brainstorming)

Example Scenario

Activity

csviri commented on Jun 4, 2024

metacosm commented on Jun 5, 2024

btlem commented on Jun 11, 2024

15 remaining items

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions