Skip to content

Every EventSource should be a ResourceEventSource #2107

New issue
New issue
Closed
#2367
Closed
Every EventSource should be a ResourceEventSource#2107
#2367
Labels
architectureneeds-discussionIssue needs to be discussed more before working on it
Milestone
5.0

Description

@csviri
csviri
opened on Oct 24, 2023

Currently even for inbound event sources that is support for event triggering the reconciliation where the event does not contain the actual resource we have a supporting class that actually fetches the resource (within the event source):

https://github.com/java-operator-sdk/java-operator-sdk/blob/47ef983dd4135a05fd6c2cd0650cf0eda1fd3c8e/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/inbound/CachingInboundEventSource.java

The question is if it makes sense to even have a non resource event source. Probably not. We have to discuss this, and probably change (thus move the API of ResourceEventSource to EventSource) for next major version .

Activity

  1. csviri
    added this to the 5.0 milestone on Oct 24, 2023
  2. csviri
    added
    architecture
    on Oct 24, 2023

  3. github-actions commented on Dec 24, 2023

    @github-actions
    github-actionsBot
    on Dec 24, 2023 – with GitHub Actions

    This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

  4. github-actions
    added
    stale
    on Dec 24, 2023
  5. csviri
    removed
    stale
    on Dec 24, 2023

  6. github-actions commented on Feb 23, 2024

    @github-actions
    github-actionsBot
    on Feb 23, 2024 – with GitHub Actions

    This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

  7. github-actions
    added
    stale
    on Feb 23, 2024
  8. csviri
    removed
    stale
    on Feb 23, 2024
  9. csviri
    added
    needs-discussionIssue needs to be discussed more before working on it
    on Mar 7, 2024
  10. csviri
    linked a pull request that will close this issuefeat: all event source is resource event source #2367on Apr 29, 2024
  11. csviri
    closed this as completedon May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    architectureneeds-discussionIssue needs to be discussed more before working on it

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions