Skip to content

Remove remove flag to compare labels & annotation from GenericKubernetesResourceMatcher #1965

New issue
New issue
Closed
#2273
Closed
Remove remove flag to compare labels & annotation from GenericKubernetesResourceMatcher#1965
#2273
Labels
kind/featureCategorizes issue or PR as related to a new feature.
Milestone
5.0

Description

@csviri
csviri
opened on Jun 23, 2023

Those should be always compared now based on the default updateMatcher implementation

Activity

  1. csviri
    added this to the 5.0 milestone on Jun 23, 2023
  2. csviri
    added
    enhancement
    on Jun 23, 2023
  3. openshift-ci-robot
    added
    kind/featureCategorizes issue or PR as related to a new feature.
    and removed
    enhancement
    on Jun 28, 2023

  4. github-actions commented on Aug 28, 2023

    @github-actions
    github-actionsBot
    on Aug 28, 2023

    This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

  5. github-actions
    added
    stale
    on Aug 28, 2023
  6. csviri
    removed
    stale
    on Aug 28, 2023

  7. github-actions commented on Oct 28, 2023

    @github-actions
    github-actionsBot
    on Oct 28, 2023

    This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

  8. github-actions
    added
    stale
    on Oct 28, 2023
  9. openshift-ci
    added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    and removed
    stale
    on Nov 8, 2023
  10. csviri
    removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Nov 13, 2023

  11. github-actions commented on Jan 13, 2024

    @github-actions
    github-actionsBot
    on Jan 13, 2024 – with GitHub Actions

    This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

  12. github-actions
    added
    stale
    on Jan 13, 2024
  13. csviri
    removed
    stale
    on Jan 13, 2024
  14. csviri
    linked a pull request that will close this issueimprove: matcher always considers metadata #2273on Mar 8, 2024
  15. csviri
    closed this as completedon Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions