You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use Sever Side Apply to Update Status and Manage Finalizers #1931
This would make more sense if the status would be written by multiple controllers, usually, that is not the case. Was checking, and neither the Kubernetes built-in operators seems to be using SSA to update the status. On the other hand this is true also for the manager resource specs. So might at the end it would be nicer to do with SSA.
For the resource update (not the status) also a little bit problematic, with SSA we just should send the intent, not the whole resource, so that might be confusing for the users that not the primary resource from the reconciler argument should be used, rather there should be the resource created from scratch and only the changes on the resource should be applied.
So what would make sense is to do is make it default for patch (with a feature flag to not do it by default), and an explicit method to path the resource with SSA - where in javadoc we articulate that only the intent should be sent.
Activity
github-actions commentedon Aug 5, 2023
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
github-actions commentedon Oct 7, 2023
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
github-actions commentedon Dec 9, 2023
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
github-actions commentedon Feb 8, 2024
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
csviri commentedon Mar 8, 2024
This would make more sense if the status would be written by multiple controllers, usually, that is not the case. Was checking, and neither the Kubernetes built-in operators seems to be using SSA to update the status. On the other hand this is true also for the manager resource specs. So might at the end it would be nicer to do with SSA.
For the resource update (not the status) also a little bit problematic, with SSA we just should send the intent, not the whole resource, so that might be confusing for the users that not the primary resource from the reconciler argument should be used, rather there should be the resource created from scratch and only the changes on the resource should be applied.
So what would make sense is to do is make it default for patch (with a feature flag to not do it by default), and an explicit method to path the resource with SSA - where in javadoc we articulate that only the intent should be sent.